NewChatFix#2102
Closed
johndev0711 wants to merge 1 commit into
Closed
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
MariaHCD
requested changes
Mar 29, 2021
MariaHCD
left a comment
MariaHCD
left a comment
Contributor
There was a problem hiding this comment.
Hi, @johndev0711! Is this ready for review? Please update the PR description with the missing sections including the link to the original issue (so that I may have context on what the PR is trying to fix) and your tests! In addition, there seem to be some JavaScript lint errors
Contributor
Author
|
Thanks for your effort.
I think that I've already updated the PR description with the original
issue link "#1968", and
this was displayed as "#1968" on the description.
And the first request has the lint errors, but I've checked them and
reopened the pull requests. If there need any correction or reopening of
the PR, inform me please.
Hope to hear from you soon.
Best regards.
Thank you.
John A.
…On Mon, 29 Mar 2021 at 08:23, MariaHCD ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi, @johndev0711 <https://github.com/johndev0711>! Is this ready for
review? Please update the PR description with the missing sections
including the link to the original issue (so that I may have context on
what the PR is trying to fix) and your tests! In addition, there seem to be
some JavaScript lint errors
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2102 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARZQPFUBT3GFLFGXUH7SUPDTGATHJANCNFSM4Z26GCFA>
.
|
Contributor
|
Thanks for the information, @johndev0711. I see that you have another PR (#2103) to fix the issue. So I believe this PR should be closed in favor of #2103. Let me know! |
Contributor
Author
|
I've sent a new pull request at the #2103. So I have to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>
Details
Fixed Issues
Fixes GH_LINKTests
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android